Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove sqlformat #3545

Merged
merged 2 commits into from
Oct 5, 2024
Merged

Conversation

tbar4
Copy link
Contributor

@tbar4 tbar4 commented Oct 4, 2024

…rmatOptions

Does your PR solve an issue?

Yes

"fixes #3544 "

@abonander abonander changed the title removed sqlformat from sql-core/src/logger.rs causing ref error to Fo… fix: remove sqlformat Oct 4, 2024
@tbar4
Copy link
Contributor Author

tbar4 commented Oct 5, 2024

Sorry forgot to do clippy and format

@tbar4
Copy link
Contributor Author

tbar4 commented Oct 5, 2024

@abonander ready to merge

@abonander abonander merged commit cadf152 into launchbadge:main Oct 5, 2024
81 checks passed
@svix-jplatte
Copy link

svix-jplatte commented Oct 7, 2024

Wasn't the broken version already yanked when this was merged? Also FYI, there's now a v0.3.0.

edit: Oh, just found

We really shouldn't be formatting queries before logging them.

in #3544. Makes sense 👍
(though you should probably delete the commented-out sqlformat calls then ^^)

jrasanen pushed a commit to jrasanen/sqlx that referenced this pull request Oct 14, 2024
* removed sqlformat from sql-core/src/logger.rs causing ref error to FormatOptions

* removed sqlformat from sql-core/src/logger.rs causing ref error to FormatOptions

---------

Co-authored-by: tbarnes <[email protected]>
jrasanen pushed a commit to jrasanen/sqlx that referenced this pull request Oct 14, 2024
* removed sqlformat from sql-core/src/logger.rs causing ref error to FormatOptions

* removed sqlformat from sql-core/src/logger.rs causing ref error to FormatOptions

---------

Co-authored-by: tbarnes <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sqlx-core error in logger.rs FormatOptions reference
3 participants